Skip to content

Conversation

@Brooooooklyn
Copy link
Member

No description provided.

Copilot AI review requested due to automatic review settings October 14, 2025 12:27
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the oxc_sourcemap dependency from version 4 to version 5, following a standard dependency maintenance pattern.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Brooooooklyn Brooooooklyn changed the title chore: update oxc-sourcemap chore(deps): update oxc-sourcemap Oct 14, 2025
@github-actions github-actions bot added the C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior label Oct 14, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Oct 14, 2025

CodSpeed Performance Report

Merging #14593 will not alter performance

Comparing 10-14-chore_update_oxc-sourcemap (930cb2f) with main (1bf83eb)

Summary

✅ 37 untouched

@Brooooooklyn Brooooooklyn requested a review from Boshen October 14, 2025 12:36
@Boshen Boshen self-assigned this Oct 14, 2025
@Boshen
Copy link
Member

Boshen commented Oct 15, 2025

MSRV is too high on:

Adding json-escape-simd v1.1.0 (requires Rust 1.89.0)

we are still on 1.88.0

oxc/Cargo.toml

Lines 16 to 18 in e7c2748

# MSRV Policy N-2 (12 weeks).
# Balance between the core contributors enjoying the latest version of rustc, while waiting for dependents to catch up.
rust-version = "1.88.0"

@Boshen Boshen marked this pull request as draft October 15, 2025 01:22
@Brooooooklyn Brooooooklyn force-pushed the 10-14-chore_update_oxc-sourcemap branch from 4a07ce0 to 930cb2f Compare October 15, 2025 05:54
@Brooooooklyn
Copy link
Member Author

@Boshen json-escape-simd v3.0.1 now requires Rust 1.85.0 rather than 1.89.0

@Boshen Boshen marked this pull request as ready for review October 15, 2025 06:40
@Boshen Boshen merged commit 6bf785b into main Oct 15, 2025
28 checks passed
@Boshen Boshen deleted the 10-14-chore_update_oxc-sourcemap branch October 15, 2025 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants