refactor(language_server): Backend checks the correct LintOptions::Run
#15166
+32
−362
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-editor
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Sysix
changed the title
Backend chekcs the correct LintOptions::RunBackend checks the correct LintOptions::Run
Sysix
changed the base branch from
10-10-refactor_language_server_use_lintrunner_
to
graphite-base/15166
Sysix
force-pushed
the
10-30-refactor_language_server_backend_chekcs_the_correct_lintoptions_run_
branch
from
f05f4ab to
f211d1e
Compare
Sysix
force-pushed
the
graphite-base/15166
branch
from
716cfc9 to
27c0255
Compare
This was referenced Oct 30, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the linter run behavior in the language server by removing the ServerLinterRun enum and moving the run type checking from the linter layer to the backend layer. The main purpose is to simplify the linter API and improve separation of concerns.
Key changes:
- Removed
ServerLinterRunenum and its matching logic fromServerLinter - Added
should_lint_on_run_typemethod toWorkspaceWorkerfor run type validation - Updated backend handlers (
did_save,did_change) to check run type before linting - Removed test fixtures and tests related to run type filtering
- Simplified
lint_filemethod signature by removing therun_typeparameter
Reviewed Changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| crates/oxc_language_server/src/worker.rs | Added should_lint_on_run_type method and removed run_type parameter from lint_file |
| crates/oxc_language_server/src/backend.rs | Added run type checks in did_save and did_change handlers before calling lint_file |
| crates/oxc_language_server/src/linter/server_linter.rs | Removed ServerLinterRun enum, removed run type matching logic from run_single, and removed related tests |
| crates/oxc_language_server/src/tester.rs | Simplified test methods by removing run type parameters |
| crates/oxc_language_server/src/snapshots/*.snap | Deleted snapshot files for removed run type tests |
| crates/oxc_language_server/fixtures/linter/lint_on_run/**/*.ts | Deleted test fixture files for run type functionality |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
camc314
approved these changes
Nov 3, 2025
Contributor
Merge activity
|
graphite-app bot
pushed a commit
that referenced
this pull request
Nov 3, 2025
…:Run` (#15166) Because `tsgolint` works now on type, the `Backend` can now be responsible to skip the linting part. This simplifies a lot :)
graphite-app
bot
force-pushed
the
10-30-refactor_language_server_backend_chekcs_the_correct_lintoptions_run_
branch
from
f211d1e to
d8a2f85
Compare
graphite-app
bot
requested review from
Dunqing and
overlookmotel
as code owners
github-actions
bot
added
A-linter
github-actions
bot
added
A-isolated-declarations
graphite-app
bot
changed the base branch from
graphite-base/15166
to
10-10-refactor_language_server_use_lintrunner_
Base automatically changed from
10-10-refactor_language_server_use_lintrunner_
to
main
November 3, 2025 14:07
Sysix
force-pushed
the
10-30-refactor_language_server_backend_chekcs_the_correct_lintoptions_run_
branch
from
d8a2f85 to
4a2477b
Compare
…:Run` (#15166) Because `tsgolint` works now on type, the `Backend` can now be responsible to skip the linting part. This simplifies a lot :)
graphite-app
bot
force-pushed
the
10-30-refactor_language_server_backend_chekcs_the_correct_lintoptions_run_
branch
from
4a2477b to
10732e8
Compare
graphite-app
bot
deleted the
10-30-refactor_language_server_backend_chekcs_the_correct_lintoptions_run_
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
tsgolintworks now on type, theBackendcan now be responsible to skip the linting part.This simplifies a lot :)