Skip to content

Conversation

@leaysgur
Copy link
Member

@leaysgur leaysgur commented Nov 4, 2025

In #14820, new rustflags for linux was added.

But it causes CI error: https://github.com/oxc-project/oxc/actions/runs/19061338376/job/54441526510#step:8:59

Copilot AI review requested due to automatic review settings November 4, 2025 08:07
@github-actions github-actions bot added the C-bug Category - Bug label Nov 4, 2025
Copy link
Member Author

leaysgur commented Nov 4, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes Linux-specific linker configuration from the Cargo build settings. The change eliminates custom rustflags that were previously applied to Linux targets, specifically removing the LLD linker feature flag and unresolved symbol warning configuration.

Key Changes:

  • Removed Linux target-specific rustflags configuration block
  • Cleaned up linker feature and link argument specifications for Linux builds

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@leaysgur leaysgur force-pushed the 11-04-fix_rust_revert_rustflags_added_in_14820 branch from 9a85b0f to a1c2891 Compare November 4, 2025 08:14
@leaysgur leaysgur changed the title fix(rust): Revert rustflags added in #14820 fix(rust): Tweak rustflags added in #14820 Nov 4, 2025
@leaysgur leaysgur force-pushed the 11-04-fix_rust_revert_rustflags_added_in_14820 branch 2 times, most recently from ea60b48 to eb1329a Compare November 4, 2025 08:27
@leaysgur leaysgur force-pushed the 11-04-fix_rust_revert_rustflags_added_in_14820 branch from eb1329a to 76b8a73 Compare November 4, 2025 08:43
@github-actions github-actions bot added A-cli Area - CLI A-formatter Area - Formatter labels Nov 4, 2025
@leaysgur
Copy link
Member Author

leaysgur commented Nov 4, 2025

Remove bin section seems not enough.

Need to remove main.rs itself too, which requires a bit refactoring.

  • Remove main.rs
  • Remove pub fn things from lib.rs, move some of them to run.rs

I will retry tomorrow.

@leaysgur leaysgur closed this Nov 6, 2025
@leaysgur leaysgur deleted the 11-04-fix_rust_revert_rustflags_added_in_14820 branch November 6, 2025 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-cli Area - CLI A-formatter Area - Formatter C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants