-
-
Notifications
You must be signed in to change notification settings - Fork 717
refactor(language_server): split ServerLinter creation with *Builder pattern
#15282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(language_server): split ServerLinter creation with *Builder pattern
#15282
Conversation
a7fd005 to
6bfe7ee
Compare
58be109 to
1e77275
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors the ServerLinter initialization to use a builder pattern, separating construction logic from the linter instance itself. The main purpose is to improve code organization and API design.
- Introduced
ServerLinterBuilderto handle the construction ofServerLinterinstances - Changed
ServerLinter::new()from a constructor to a simpler initialization method - Updated the
refresh_server_linter()method to take ownedLintOptionsinstead of a reference
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| crates/oxc_language_server/src/worker.rs | Updated all call sites to use the new ServerLinterBuilder API and changed refresh_server_linter parameter from reference to owned value |
| crates/oxc_language_server/src/linter/server_linter.rs | Split ServerLinter into two types: ServerLinterBuilder for construction logic and ServerLinter for runtime operations |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Merge activity
|
6bfe7ee to
98d7869
Compare
…er` pattern (#15282) > This PR refactors the ServerLinter initialization to use a builder pattern, separating construction logic from the linter instance itself. The main purpose is to improve code organization and API design.
1e77275 to
06bbb5d
Compare
98d7869 to
000a891
Compare
…er` pattern (#15282) > This PR refactors the ServerLinter initialization to use a builder pattern, separating construction logic from the linter instance itself. The main purpose is to improve code organization and API design.
06bbb5d to
5f81e63
Compare
…er` pattern (#15282) > This PR refactors the ServerLinter initialization to use a builder pattern, separating construction logic from the linter instance itself. The main purpose is to improve code organization and API design.
5f81e63 to
55222ab
Compare

Uh oh!
There was an error while loading. Please reload this page.