[nexus-db-queries] use cargo nextest bench #8413
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.6-beta.1
Created using spr 1.3.6-beta.1
sunshowers
changed the title
Created using spr 1.3.6-beta.1
smklein
reviewed
Jan 5, 2026
| group.bench_function(&name, |b| { | ||
| // Force evaluation of the harness outside to_async to | ||
| // avoid nested block_on. | ||
| let harness = &*harness; |
Collaborator
There was a problem hiding this comment.
Nit; I think there's a method called Lazy::force to do the same thing as this https://doc.rust-lang.org/std/cell/struct.LazyCell.html#method.force with the intention of being explicit. Don't have a strong preference about it tho
| // You can run these with the following command: | ||
| // | ||
| // ```bash | ||
| // cargo bench -p nexus-db-queries |
Collaborator
There was a problem hiding this comment.
If someone still uses the cargo bench invocation, do we have a way to tell that poor developer to "please use nextest; if you use cargo bench, your database won't get configured correctly"?
smklein
approved these changes
Jan 5, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New in cargo-nextest 0.9.117: see https://nexte.st/docs/features/benchmarks.