PI-12: Add support for private VCS dependencies#47
Open
robertjdevita wants to merge 2 commits intomainfrom
Open
PI-12: Add support for private VCS dependencies#47robertjdevita wants to merge 2 commits intomainfrom
robertjdevita wants to merge 2 commits intomainfrom
Conversation
Add comments to the top of the YAML with details about the required secrets and variables.
robertjdevita
changed the title
Made the following changes: 1. Checks composer.json for VCS-type repos before composer install 2. Validates token presence if private deps are found 3. Fails with clear error if token is needed but missing 4. Uses token conditionally - only if it exists 5. Updated documentation in comments about when COMPOSER_GITHUB_TOKEN is needed
Contributor
|
@robertjdevita Do we really need this here or was this just for testing? |
Contributor
Author
|
@agentrickard it was for testing. We can discard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add comments to the top of the YAML with details about the required secrets and variables.