TYP: patch for astral-sh/ty#1846 #1547
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
cmp0xff
commented
Dec 14, 2025
Comment on lines
+115
to
+117
| index: _NonIterableHashable | Sequence[Hashable] = ..., | ||
| columns: _NonIterableHashable | Sequence[Hashable] = ..., | ||
| values: _NonIterableHashable | Sequence[Hashable] = ..., |
Contributor
Author
There was a problem hiding this comment.
I don't see the three different type variables HashableT1 ... HashableT3 being helpful in anyway here. Changing to Hashable.
Dr-Irv
approved these changes
Dec 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes ty fixed issue with
Protocol#1530With https://github.com/astral-sh/ty/releases/tag/0.0.1-alpha.34, the error message reported in don't discard "unused" typevars from generic context of simplified generic type alias astral-sh/ty#1846 has shifted.
If we remove
HashableT1,HashableT2, etc., which are not used, we can remove the error messages.