fix(sim): clamp bundle timeout to max instead of falling back to default #18840
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When users specify a
timeout
value greater thanMAX_SIM_TIMEOUT
in bundle simulation, the current logic silently falls back toDEFAULT_SIM_TIMEOUT
instead of clamping to the maximum allowed value. This leads to unexpected behavior where large timeout values result in shorter-than-expected timeouts.Solution
Replace the
filter()
+unwrap_or()
pattern with explicitmin()
clamping to ensure predictable timeout behavior.