refactor(merkle): prevent overlapping chunk ranges in incremental trie updates #20086
+3
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem
The incremental merkle update loop uses range.step_by(incremental_threshold) combined with inclusive range start_block..=chunk_to, which causes boundary blocks to be processed twice.
Before (log / overlapping):
Solution
Replace step_by iterator with a while loop that advances start_block to chunk_to + 1, ensuring non-overlapping ranges.
After (log / non-overlapping):
Note
The current merkle algorithm is idempotent, so correctness is unaffected. This fix eliminates redundant computation and ensures correctness if the implementation ever becomes non-idempotent.