Index update #46
Merged
Index update #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handy-caT
commented
Feb 8, 2025
Handy-caT
commented
Feb 8, 2025
Handy-caT
commented
Feb 8, 2025
Handy-caT
commented
Feb 8, 2025
| if let Some(diff) = difference.get(stringify!(#diff_key)) { | ||
| match &diff.old { | ||
| #avt_type_ident::#variant_ident(old) => { | ||
| if let Some(set) = TableIndex::peek(&self.#index_field_name, old) { |
There was a problem hiding this comment.
Why do you expect set here? Set will be returned only for non-unique indexes. Also, this is outdated. In last commit in main I removed TableIndex because for now only indexset supports all functionality that is needed for wt, so you need to merge main and rework this
There was a problem hiding this comment.
You are right, I missed the case of unique indecies because first of all I tried to implement non-unique, thank you
Handy-caT
commented
Feb 8, 2025
Handy-caT
commented
Feb 8, 2025
Handy-caT
commented
Feb 11, 2025
Handy-caT
added
documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.