Skip to content

Conversation

@hannesm
Copy link

@hannesm hannesm commented Aug 23, 2025

Dear @patricoferris (and maybe @djs55 is interested as well),

I fixed the issue at moby#646 (comment) by using the mirage-mtime.mock sublibrary.

This branch now compiles, what is needed though (pending releases I guess):

So, if you agree, I'd cut releases of these three opam packages in the mirage organization (after merging the mentioned outstanding PRs).

@patricoferris
Copy link
Owner

Thanks @hannesm !

This seems sensible to me, shall I hold off until the reset function lands to merge this change in the PR ?

@hannesm
Copy link
Author

hannesm commented Aug 24, 2025

See ocaml/opam-repository#28392 -- once that is merged, it should be good (we may want to have a lower bound { >= "5.1.0" } in the vpnkit.opam though.

@hannesm
Copy link
Author

hannesm commented Aug 24, 2025

And while at it, the 9p release ocaml/opam-repository#28394 and hvsock ocaml/opam-repository#28393

@hannesm
Copy link
Author

hannesm commented Aug 24, 2025

I pushed a change with the bounds, this will only work once the above mentioned opam packages have been merged into the opam-repository.

@hannesm
Copy link
Author

hannesm commented Aug 28, 2025

Note the releases are merged in opam-repository now, so this should be fine to compile and being merged.

@patricoferris patricoferris merged commit 69e8080 into patricoferris:updating-mirage Aug 28, 2025
@hannesm hannesm deleted the fix branch August 28, 2025 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants