Use shared jQuery references instead of repeately querying DOM#101
Open
tommcc wants to merge 2 commits intopattern-lab:developfrom
Open
Use shared jQuery references instead of repeately querying DOM#101tommcc wants to merge 2 commits intopattern-lab:developfrom
tommcc wants to merge 2 commits intopattern-lab:developfrom
Conversation
added 2 commits
October 30, 2017 11:50
… instead of querying the DOM every time.
…e DOM every time.
Member
|
Hey @tommcc! Thanks so much for helping clean up the JavaScript files. This is fantastic work that cleans things up nicely. Eye-balling it looks good from my end, but I'd need some help from @bmuenzenmeyer or somebody to help me pull it down and test things for real. I'm a bit clumsy in that department. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change aims to improve readability and efficiency by reducing repeated DOM and/or jQuery selectors I found in
styleguide.js.$sgIframe$sgIframeContainerand$sgViewportCoverand replace queries with them.In cases where an instance of the repeated query was a jQuery selector, simply use the earlier-defined jQuery reference. In cases where a native
document.querySelector()is used, I call jQuery's.get(0), which pulls out the native DOM element from the reference. In either case, the DOM shouldn't have to be searched again for the same elements over and over.I particularly focused on making these replacements in connection with the
mousemoveevent while dragging the iframe handle, which can potentially be triggered many times per second.