Skip to content

docs: remove skip link animation #2554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zeroedin merged 2 commits into from
Jul 14, 2023
Merged

docs: remove skip link animation #2554

zeroedin merged 2 commits into from
Jul 14, 2023

Conversation

@zeroedin
Copy link
Contributor

@zeroedin zeroedin commented Jul 13, 2023 •
edited
Loading

What I did

  1. Removed skip link animation so link doesn't animate at page load

Closes #2553

Testing Instructions

  1. View Deploy Preview

Notes to Reviewers

  1. If you view patternflyelements.org before this PR is merged you'll notice on page loads the skip link will animate that was unintended. This PR removes the animation all together as it really isn't needed for the links main purpose.

@zeroedin zeroedin added the docs Documentation updates label Jul 13, 2023
@zeroedin zeroedin added this to the PatternFly Elements 2.x milestone Jul 13, 2023
@zeroedin zeroedin requested a review from nikkimk July 13, 2023 13:38
@zeroedin zeroedin self-assigned this Jul 13, 2023
@changeset-bot
Copy link

changeset-bot bot commented Jul 13, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: a3fa621

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added doc AT passed Automated testing has passed labels Jul 13, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 13, 2023 •
edited
Loading

✅ Deploy Preview for patternfly-elements ready!

Name Link
🔨 Latest commit 99c70be
😎 Deploy Preview https://deploy-preview-2554--patternfly-elements.netlify.app/

To edit notification comments on pull requests, go to your Netlify site settings.

nikkimk
nikkimk approved these changes Jul 14, 2023
View reviewed changes
Copy link
Contributor

@nikkimk nikkimk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lint gets too messy

@zeroedin zeroedin merged commit 782c0ae into main Jul 14, 2023
@zeroedin zeroedin deleted the docs/remove-skip-link-animation branch July 14, 2023 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@nikkimk nikkimk nikkimk approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@zeroedin zeroedin

Labels

AT passed Automated testing has passed docs Documentation updates ready to merge

Projects

None yet

Milestone

PatternFly Elements 2.x

Development

Successfully merging this pull request may close these issues.

[docs] skip link visible on page load

3 participants

@zeroedin @nikkimk