ENH: add xrt to camviewer script, don't ssh if you don't need to#331
ENH: add xrt to camviewer script, don't ssh if you don't need to#331ZLLentz wants to merge 2 commits intopcdshub:masterfrom
Conversation
silkenelson
left a comment
There was a problem hiding this comment.
As in the comment - I'd like to make sure we are dealing ok with the XBDO machine otherwise the machine-name approach is fine for now.
There was a problem hiding this comment.
Is checking for the console machines still sufficient? Don't we need to include the XBDO machine in 901 in this list? Ideally, we'd check for the network interfaces instead of listing machines, but that could be an improvement pull request for later.
There was a problem hiding this comment.
You're right, this could do a little more without much extra effort
Let's include just the xbdo machine for now since that one definitely doesn't need an ssh, putting in another name is trivial, and it will have immediate helpful impact.
Later we can check our interface list as you say- this would mostly be for running camViewer on ioc machines at this point, but it would future-proof us for certain configuration changes/additional consoles
Description
xrtas a valid option forcamViewerxrtas a valid hutch forverify-hutchxrtssh you tolfe-consoleto open the guiMotivation and Context
@patoppermann asked me about ssh-ing to avoid bad gateway performance for camViewer, this is his code from last year but extended to allow xrt
Small cleanup while here
How Has This Been Tested?
Interactively only
Where Has This Been Documented?
Here only