Skip to content

Added a feature to try to detect the language of lyrics. The language…#4324

Open
halleck1 wants to merge 23 commits intopear-devs:masterfrom
halleck1:synced-lyrics-skip-languages
Open

Added a feature to try to detect the language of lyrics. The language…#4324
halleck1 wants to merge 23 commits intopear-devs:masterfrom
halleck1:synced-lyrics-skip-languages

Conversation

@halleck1
Copy link

… would by default be shown in the Lyrics panel and the songs can be optionally skipped and/or disliked

Volodymyr Tymchenko and others added 11 commits February 16, 2026 12:53
… would by default be shown in the Lyrics panel and the songs can be optionally skipped and/or disliked
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds lyrics language detection to the Synced Lyrics plugin, surfaces the detected language in the UI, and introduces optional auto-skip/auto-dislike behavior based on a configurable list of language codes.

Changes:

  • Extend lyrics results with an optional language field and plugin config with auto-skip/auto-dislike options.
  • Detect lyrics language (via tinyld) during provider fetches and display it as a badge in the Lyrics picker UI.
  • Add menu entries + i18n strings for configuring auto-skip languages and whether to dislike before skipping.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
src/plugins/synced-lyrics/types.ts Adds config fields and LyricResult.language to support language-based behavior and display.
src/plugins/synced-lyrics/style.css Introduces styling for provider+language display and the language badge.
src/plugins/synced-lyrics/renderer/store.ts Adds language detection during lyric fetch/retry and stores it on results.
src/plugins/synced-lyrics/renderer/renderer.tsx Implements auto-skip/auto-dislike behavior based on detected lyric language.
src/plugins/synced-lyrics/renderer/components/LyricsPicker.tsx Displays detected language badge under the provider name.
src/plugins/synced-lyrics/menu.ts Adds menu items + prompt/checkbox to configure auto-skip and auto-dislike.
src/i18n/resources/en.json Adds English strings for the new menu items and prompt labels.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Volodymyr Tymchenko and others added 2 commits February 27, 2026 18:06
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Volodymyr Tymchenko added 2 commits March 2, 2026 14:55
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Volodymyr Tymchenko and others added 2 commits March 2, 2026 15:12
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 5 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Volodymyr Tymchenko and others added 2 commits March 2, 2026 16:23
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants