Fix up deprecation warnings that show up with JDK's that are more rec… #117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ent than version 1.8. Mostly these are replacing the boxed primitive constructors with the static valueOf method. In the Reflect class test that the package is exported from the module before using trySetAccessible in order to prevent a warning about illegal access.
jimjag
added a commit
to jimjag/beanshell2
that referenced
this pull request
Dec 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ent than version 1.8. Mostly these are replacing the boxed primitive constructors with the static valueOf method. In the Reflect class test that the package is exported from the module before using trySetAccessible in order to prevent a warning about illegal access.
It seems like this project is pretty dormant, but I thought I would pass this along in case anyone else is interested. I went through the code to clean up the deprecation messages that show up when building for a JDK11 target. I realize that BeanShell2 is targeted for JDK1.8, but I wanted to squelch a run time message that shows up about an illegal module access in the Reflect class, and all of the other deprecation messages were easy pickings.