Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions helper/diffPlaces.js
Original file line number Diff line number Diff line change
Expand Up @@ -157,6 +157,7 @@ function isAddressDifferent(item1, item2){
if( !isPojo1 || !isPojo2 ){ return false; }

// else both have address info
if( isPropertyDifferent(address1, address2, 'unit') ){ return true; }
if( isPropertyDifferent(address1, address2, 'number') ){ return true; }
if( isPropertyDifferent(address1, address2, 'street') ){ return true; }

Expand Down
39 changes: 39 additions & 0 deletions test/unit/helper/diffPlaces.js
Original file line number Diff line number Diff line change
Expand Up @@ -438,6 +438,45 @@ module.exports.tests.dedupe = function(test, common) {
t.end();
});

test('same address, different unit number', function (t) {
var item1 = {
'address_parts': {
'unit': '1',
'number': '10',
'street': 'Main Street'
}
};
var item2 = {
'address_parts': {
'unit': '2',
'number': '10',
'street': 'Main Street'
}
};

t.true(isDifferent(item1, item2), 'should be different');
t.end();
});

test('same address, different one missing unit number', function (t) {
var item1 = {
'address_parts': {
'number': '10',
'street': 'Main Street'
}
};
var item2 = {
'address_parts': {
'unit': '2',
'number': '10',
'street': 'Main Street'
}
};

t.true(isDifferent(item1, item2), 'should be different');
t.end();
});

test('completely empty objects', function(t) {
var item1 = {};
var item2 = {};
Expand Down