Minor XS simplifications #122
Conversation
Tux
left a comment
Tux
left a comment
There was a problem hiding this comment.
DBI is expected to run on 5.8.0, so for these kind of changes we should heavily depend on Devel::PPPort and its reports. DBI's version of ppport.h is dbipport. My own git checkout has a symlink from the last to the first. Problem with using it is that - due to that name choice - the tool keeps suggesting to add it.
The current Devel::PPPort suggests to remove the Perl_ prefixes completely, and I tend to agree, but as this has no functional or visible change (yet), I decided to postpone that work till after the 1.644 release
Tux
left a comment
Tux
left a comment
There was a problem hiding this comment.
This now botches with the accepted change already merged. Could you do this one on a fresh checkout please?
As per the docs, the perl_require_pv form is deprecated. Note I think the second of these calls is actually a bug since profile_class is a package name with colons, not a filename with slashes. We're not currently checking ERRSV after this call so it's probably silently failing. But such a fix is out of scope of this commit. Also it's probably worth moving to load_module instead as per the docs: It is analogous to the Perl code eval "require '$file'". It's even implemented that way; consider using load_module instead.
Also use an XPUSH macro to replace as explicit EXTEND.
Note hv_stores also drops the trailing hash param from its hv_store counterpart as the hash is computed automatically at compile time.
|
Rebased to account for #133 being merged. |
|
Thank you! |
2 participants
Collection of XS simplifications, see each commit for details.
Also I think I've found a bug, see the first commit for details.