Skip to content

ref: Refactor phone number validation to improve readability and logic. #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

ref: Refactor phone number validation to improve readability and logic. #24

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions persian_tools/phone_number/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

MOBILE_REGEX = '(?:[+|0{2}]?98)?(?:0)?(\\d{3})+(\\d{3})+(\\d{4})'
VALID_TOKENS = ['+98', '98', '0098', '0']
MOBILE_SUFFIX_REGEX = '^(?:\+98|98|0098|0)'
MOBILE_SUFFIX_REGEX = r'^(?:\+98|98|0098|0)'


def _get_operator_data(phone_number: str) -> Union[dict, bool]:
Expand All @@ -19,8 +19,14 @@ def _get_operator_data(phone_number: str) -> Union[dict, bool]:


def validate(phone_number: str) -> bool:
return _get_operator_data(phone_number) is not False
operator = _get_operator_data(phone_number)
if not operator:
return False

if not re.fullmatch(MOBILE_REGEX, phone_number):
return False

return True

def operator_data(phone_number: str) -> bool:
res = _get_operator_data(phone_number)
Expand Down