Fix --compact CLI flag not activating compact output#1652
Open
isaackaara wants to merge 1 commit intopestphp:5.xfrom
Open
Fix --compact CLI flag not activating compact output#1652isaackaara wants to merge 1 commit intopestphp:5.xfrom
isaackaara wants to merge 1 commit intopestphp:5.xfrom
Conversation
The --compact flag was listed in the help output but never actually handled by any plugin. This adds handling in the Printer plugin to call DefaultPrinter::compact(true) when --compact is passed, matching the behavior of pest()->printer()->compact().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1632
The
--compactflag is listed in the help output but was never actually handled by any plugin. Runningpest --compacthad no effect on the output format — tests still displayed in the default verbose style.This adds handling in the
Printerplugin to callDefaultPrinter::compact(true)when--compactis passed as a CLI argument, which is the same thingpest()->printer()->compact()does in Pest.php config.