fix: nested dataset discovery and parallel invalid-dataset reporting#1655
Open
stsepelin wants to merge 3 commits intopestphp:4.xfrom
Open
fix: nested dataset discovery and parallel invalid-dataset reporting#1655stsepelin wants to merge 3 commits intopestphp:4.xfrom
stsepelin wants to merge 3 commits intopestphp:4.xfrom
Conversation
stsepelin
commented
Mar 26, 2026
| $output = function () use ($testsPath) { | ||
| $process = (new Process( | ||
| ['php', 'bin/pest'], | ||
| ['php', '-d', 'memory_limit=256M', 'bin/pest'], |
Author
There was a problem hiding this comment.
I'm not quite sure about this change. After the snapshots.txt update, the default PHP config (128M memory limit) started failing with memory limit warnings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
Description:
This PR follows up on #1427 and fixes two related problems in Pest's parallel execution flow.
First, it fixes nested dataset discovery for datasets stored in nested
Datasets/directories, addressing #1121.Second, it fixes parallel reporting when a dataset is invalid or missing, so these cases are surfaced correctly as failures rather than being lost in the summary, addressing #1185.
The PR also adds regression coverage for both scenarios and keeps the success snapshot coverage in place with a lower memory limit for the visual snapshot test.
Related: