Open
Conversation
pferate
requested changes
Oct 27, 2017
Owner
pferate
left a comment
pferate
left a comment
There was a problem hiding this comment.
Need a new class, don't raise HttpServerError directly.
| if response.status_code == 404: | ||
| raise exceptions.HttpNotFoundError | ||
| if response.status_code == 503: | ||
| raise exceptions.HttpServerError |
Owner
There was a problem hiding this comment.
exceptions.HttpServerError is a base class for 5xx errors, not meant to be raised directly; similar to exceptions.HttpClientError.
If we are to raise an exception for 5xx, create a new class (based from HttpServerError), then raise that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've seen 503 errors when iterating through large query sets, so raise an exception rather than falling through into the next code block.