give exported __pgrx_internals_fn_* functions unique names
#2131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's entirely possible for a pgrx extension to have functions like this:
```rust
mod a {
#[pg_extern]
fn foo() { }
}
mod b {
#[pg_extern]
fn foo() { }
}
```
These are two distinct functions in Rust, and should be in the SQL
schema, but the naming of the sql entity graph `__pgrx_internals_fn_*`
function isn't unique enough.
We could also include the schema name there, but I don't think that's
quite enough, so instead we just append a UUIDv4 value.
Why don't two |
They do! But that's not what I'm trying to fix here. There'd be no way to "fix" what you're describing without changing how we name every exported |
|
I'll leave this PR for now. I'm trying to get f-ing CI to work so I can release support for pg18. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's entirely possible for a pgrx extension to have functions like this:
These are two distinct functions in Rust, and should be in the SQL schema, but the naming of the sql entity graph
__pgrx_internals_fn_*function isn't unique enough and causes compilation problems.We could maybe include the schema name here, but I don't think that's quite enough, so instead we just append a UUIDv4 value.