Allow XMPP Server to be different from JID domain#41
Open
stevenlivz wants to merge 23 commits intopgstath:masterfrom
Open
Allow XMPP Server to be different from JID domain#41stevenlivz wants to merge 23 commits intopgstath:masterfrom
stevenlivz wants to merge 23 commits intopgstath:masterfrom
Conversation
… different from the XMPP hostname in the Jid.
|
Hi, You have updated the nuget package too? Thanks. |
…olution when connections are dropped.
* Sharp.Xmpp.csproj: * Sharp.Xmpp.userprefs:
from an XmlElement (h/t pgstath#14)
…& caused compile & deployment issues..
Make it possible to retrieve the room which spawned GroupPresenceEventArgs
This was referenced Oct 29, 2018
|
@stevenlivz This is a really useful core PR, but it looks like your entire development process get pulled into it. Usually the best approach to Git Flow is to create a branch in your repo for a PR, do the changes, and then create the PR from that branch. It looks like you created a PR from your master branch, so as you made additional changes, the PR grew out of control. Would you mind cherry picking the first commit (9d5477a) off into a new branch and creating a new PR? Hopefully that could resolve folks problems (#65, #58, #34), and mine as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added support for specifying the XMPP server to connect to when it s different from the XMPP hostname in the JID.