Skip to content

Revert "Revert "New rule: Presenter should not redefine new""#1864

Open
jecisc wants to merge 1 commit intoPharo14from
revert-1863-revert-1862-Rules/firstRules
Open

Revert "Revert "New rule: Presenter should not redefine new""#1864
jecisc wants to merge 1 commit intoPharo14from
revert-1863-revert-1862-Rules/firstRules

Conversation

@jecisc
Copy link
Copy Markdown
Member

@jecisc jecisc commented Dec 15, 2025

Reverts #1863

In order to merge this PR we need to load Spec after the model of rules in Pharo

@estebanlm
Copy link
Copy Markdown
Member

so... ?

@tinchodias
Copy link
Copy Markdown
Contributor

What is this?

@Ducasse
Copy link
Copy Markdown
Contributor

Ducasse commented Mar 13, 2026

It was about a rule that make sure that people do not use new for Presenter but only newApplication: but it did not work.

@estebanlm
Copy link
Copy Markdown
Member

yeah... the idea is that no presenter can be created ourside its POM (Presenter Object Model).
The problem is that sometimes you need to first create a presenter, and after add it to a POM, and that is complicated to change.
but other times people just create them just because they can... and that's bad.
I was thinking to create a explicit way like adding some newDetached for example... and a validation when things will be displayed... that at least would make the problem explicit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants