Open
Conversation
Member
jhedstrom
commented
Jan 5, 2017
- Fixes Defer to phpcs.xml/phpcs.xml.dist when present #311
Member
Author
|
This probably needs some tests. Also, it may require changes to |
603bed5 to
bf1c0e4
Compare
Member
Author
|
Need to add 2 warnings here:
|
grayside
suggested changes
Aug 29, 2017
Contributor
grayside
left a comment
There was a problem hiding this comment.
Extra warning-handling requirement noted by @jhedstrom in comment.
bf1c0e4 to
78bb3b8
Compare
Member
Author
|
@grayside I've added the first warning, but cannot remember how the second warning actually differs. |
Member
Author
|
Hmm, this still needs a bit of work I think. The standard in the phpcs file isn't actually being used as the code in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.