Allow task-specific Composer arguments and apply defaults#320
Open
arithmetric wants to merge 2 commits intomasterfrom
Open
Allow task-specific Composer arguments and apply defaults#320arithmetric wants to merge 2 commits intomasterfrom
arithmetric wants to merge 2 commits intomasterfrom
Conversation
…de and task-specific configuration. Updating default tasks for multi task mode.
grayside
reviewed
Mar 3, 2017
Contributor
grayside
left a comment
There was a problem hiding this comment.
The doubling up of the task target looks really strange, is the idea that the first instance tells composer which command to run and the second which configuration to use?
Contributor
|
This is surfacing bugs in the package command for Drupal 8, which we already know is badly broken. Going to play with this some more but will probably merge as a precursor to fixing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #319.
Changes:
At this point, this has a potential breaking change, since the Grunt commands
composer:installandcomposer:updateno longer work and must be changed tocomposer:install:installandcomposer:update:update.