[phx gen.auth] test on page content not page nav content #6457
+13
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nduitz
changed the title
nduitz
changed the title
josevalim
approved these changes
Sep 23, 2025
SteffenDE
approved these changes
Sep 24, 2025
There was a problem hiding this comment.
We can also have more specific assertions. The only downside is that they need to communicate with the view, so they are probably slightly slower than the simple string match.
Instead of
refute html =~ "Confirm my account"
assert html =~ "Log in"you could do
refute has_element?(lv, "button", "Confirm my account")
assert has_element?(lv, "button", "Log in")This should fail for content that is only part of the root layout, has has_element? searches the current LiveView's HTML only.
Preferences, @josevalim?
|
Yes, I like the button assertions! |
|
I'll follow this up with another PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test currently asserts on the "Log in" text rendered in the root layout's default navigation.
IMHO this should assert on actual page content instead of nav bar content.
Maybe it was meant to assert on this "Log in":
phoenix/priv/templates/phx.gen.auth/confirmation_live.ex
Line 50 in db21e45
But that would require the user to be already logged in, not just to be confirmed and would require a different test that I tried to implement.
However the problem with that test is that the assertion is also satisfied by the nav bar content.