Simplify Twig templates with pre-computed values#100
Merged
dereuromark merged 1 commit intomasterfrom Mar 23, 2026
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #100 +/- ##
============================================
- Coverage 83.11% 83.09% -0.03%
- Complexity 1415 1447 +32
============================================
Files 41 42 +1
Lines 3477 3543 +66
============================================
+ Hits 2890 2944 +54
- Misses 587 599 +12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Introduces TemplateDataPreparer class that moves conditional logic from Twig templates into PHP for better maintainability and testability. Pre-computed values (no PHP code generation): - needsInvalidArgumentException/needsRuntimeException (DTO-level) - useWithMethod, needsOrFailMethod, needsHasMethod (field flags) - useImmutableCollectionMethods, useMutableCollectionMethods (field flags) - propertyVisibility, propertyTypeHint, propertyDefault (property declaration) Templates simplified: - dto.twig: Removed 7-line exception detection loop - methods.twig: Replaced dense conditionals with readable flag checks - property.twig: Simplified complex line to use pre-computed values
43dd3d8 to
8f70c5d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Introduces
TemplateDataPreparerclass that moves conditional logic from Twig templates into PHP for better maintainability and testability.Key principle: Only extract logic that computes flags/values - no PHP code generation inside PHP.
Pre-computed values
DTO-level:
needsInvalidArgumentException- true if any field is requiredneedsRuntimeException- true if any field is nullable or has associative singularField-level flags:
useWithMethod- use with* methods (immutable DTOs)needsOrFailMethod- generate *OrFail variants (nullable fields)needsHasMethod- generate has* methoduseImmutableCollectionMethods- withAdded/withRemoveduseMutableCollectionMethods- add/removeProperty declaration:
propertyVisibility- 'protected' or 'public readonly'propertyTypeHint- computed type hintpropertyDefault- default value stringTemplates simplified
What we intentionally kept in Twig
method_get.twig- kept as template conditionals to avoid generating PHP inside PHP