suggestions for php_cli PR #1782
Conversation
| #include <SAPI.h> | ||
| #include <Zend/zend_alloc.h> | ||
| #include <Zend/zend_exceptions.h> | ||
| #include <Zend/zend_interfaces.h> | ||
| #include <Zend/zend_types.h> | ||
| #include <errno.h> | ||
| #include <ext/spl/spl_exceptions.h> | ||
| #include <ext/standard/head.h> | ||
| #include <inttypes.h> | ||
| #include <php.h> | ||
| #include <php_config.h> | ||
| #include <php_ini.h> | ||
| #include <php_main.h> | ||
| #include <php_output.h> | ||
| #include <php_variables.h> | ||
| #include <php_version.h> |
There was a problem hiding this comment.
these are most definitely not all needed, but you can adjust that later @withinboredom
|
The debug trace (and the fact that it doesn't happen in my static build) leads me to believe that the segfault occurs due to linking against both libphp.a and libphp.so. Unfortunately I don't have a different solution for the |
|
@withinboredom do you have time to proceed with this by chance? I've thought of a new feature that would require this as a precursor. I'm really not familiar enough with php internals to understand the dependency on the tlsrm symbol yet. |
|
I'm not sure to understand, is this PR reviewable on its own? |
|
No. It's just a bunch of necessary changes to get #1757 going. This PR tries to merge into the refactor/cli branch, not into main. |
|
To explain it a bit more: this keeps compatibility with php <= php 8.4 (current |
|
Ah yes, got it. Thanks! I missed the target branch |
2 participants
No description provided.