Skip to content

Conversation

@realFlowControl
Copy link

This PR adds some documentation for extension developers regarding the specifics of supporting FrankenPHP worker mode.

While observing idle phases we stumbled over this and fixed our invalid handling in DataDog/dd-trace-php#3169, this PR adds some docs for future generations.

@realFlowControl realFlowControl force-pushed the florian/worker-mode-ext-docs branch from b5e485e to d38cc59 Compare August 19, 2025 10:37
Copy link
Member

@alexandre-daubois alexandre-daubois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

Copy link
Member

@dunglas dunglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition, thanks!

Don't hesitate to add a code snippet or a link to the code in a project using this trick (if open source).

@realFlowControl
Copy link
Author

realFlowControl commented Aug 20, 2025

@dunglas would you think this link would make sense?

https://github.com/DataDog/dd-trace-php/blob/e8bedafba359a08710c082a221dfbb3e6cc4624b/profiling/src/timeline.rs#L328-L341

As most extensions are written in C (and not Rust), the link might be not too helpful, I could provide a short C example next week, WDYT?

@dunglas
Copy link
Member

dunglas commented Aug 25, 2025

Both would be the best :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants