Skip to content

Conversation

@dantownsend
Copy link
Member

Resolves #440

@dantownsend dantownsend added the bug Something isn't working label Mar 19, 2025
@dantownsend dantownsend added this to Bugs Mar 19, 2025
@sinisaos
Copy link
Member

@dantownsend I don't know if this helps, but the Playwright test passes if we change the response url from this

with page.expect_response(
lambda response: response.url
== f"{BASE_URL}/api/tables/sorted_columns/?__readable=true&__order=integer,letter&__page_size=15&__page=1" # noqa: E501
and response.request.method == "GET"
and response.status == 200
):

to this

with page.expect_response(
    lambda response: "/tables/sorted_columns/?" in response.url
):

@dantownsend
Copy link
Member Author

@dantownsend I don't know if this helps, but the Playwright test passes if we change the response url from this

with page.expect_response(
lambda response: response.url
== f"{BASE_URL}/api/tables/sorted_columns/?__readable=true&__order=integer,letter&__page_size=15&__page=1" # noqa: E501
and response.request.method == "GET"
and response.status == 200
):

to this

with page.expect_response(
    lambda response: "/tables/sorted_columns/?" in response.url
):

@sinisaos Thanks - I'll give that a go!

@github-actions
Copy link

github-actions bot commented May 1, 2025

This PR has been marked as stale because it has been open for 30 days with no activity. Are there any blockers, or should this be closed?

@github-actions github-actions bot added the Stale label May 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working Stale

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

Frontend doesn't take into account the page_size parameter

3 participants