Misc Virtualizer Fixes #325
Merged
+67
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unclear if this will fix the issues people have been seeing, but it's a start
* Fixed a bug where contentContainer wasn't tracked right * Ensure we cleanup everything on virtualizer.cleanUp * Adds an instance id to Virtualizer to be more consistent with the other components
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses several virtualization edge cases discovered via the OpenCode test implementation, focusing on correcting visibility/render-window calculations and improving lifecycle cleanup to reduce stale state and leaks.
Changes:
- Adjusts window-spec computation to better handle small/zero scrollHeight scenarios and prevent invalid top/bottom windows.
- Fixes Virtualizer sizing/visibility bookkeeping by caching the content container, improving resize debugging, and expanding cleanup/reset behavior.
- Resets cached render ranges on visibility changes and tweaks initial layout/top-offset computation order for virtualized file renderers.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/diffs/src/utils/createWindowFromScrollPosition.ts | Updates window calculation/clamping to avoid stale/invalid render windows. |
| packages/diffs/src/components/Virtualizer.ts | Caches content container, improves visibility bookkeeping, and expands cleanup behavior. |
| packages/diffs/src/components/VirtualizedFileDiff.ts | Resets cached renderRange on visibility changes; adjusts first-render/top computation and debug logging. |
| packages/diffs/src/components/VirtualizedFile.ts | Adjusts first-render/top computation and debug logging to reduce init races/noise. |
| apps/demo/src/main.ts | Adds a demo “Clean” button to invoke instance cleanup. |
| apps/demo/index.html | Adds the “Clean” button to the demo UI. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The OpenCode test implementation of virtualization exposed a bunch of subtle bugs around visibility. I'm hopeful these will also fix some of the issues that Conductor was having as well.