Add configureFrom: tests and improve checker configuration coverage

src/Microdown-BookTester-Tests/MiCheckerEngineTest.class.st

@@ -29,24 +29,45 @@ MiCheckerEngineTest >> setUp [
 ]
 
 { #category : 'running' }
-MiCheckerEngineTest >> testEngineDetectsHeaderMistake [
-	| config results |
+MiCheckerEngineTest >> testCheckersFromConfiguration [
+	| config checkers |
 	config := OrderedDictionary new.
-	config at: 'HeaderCapitalization' put: 'uppercase'.
-	results := engine runOn: file withConfiguration: config.
-	self deny: results isEmpty.
-	self assert: results size equals: 3.
+	config at: 'EnglishTypography' put: nil.
+	config at: 'HeaderCapitalization' put: 'lowercase'.
+	checkers := engine checkersFromConfiguration: config.
+	self assert: checkers size equals: 2.
+	self assert: (checkers anySatisfy: [:c | c isKindOf: MicEnglishTypographyChecker]).
+	self assert: (checkers anySatisfy: [:c | c isKindOf: MicRuleHeaderChecker]).
 ]
 
 { #category : 'running' }
-MiCheckerEngineTest >> testEngineDetectsVocabularyMistake [
+MiCheckerEngineTest >> testCheckersFromConfigurationAllCheckers [
+	| config checkers |
+	config := OrderedDictionary new.
+	config at: 'EnglishTypography' put: nil.
+	config at: 'FrenchTypography' put: nil.
+	config at: 'HeaderCapitalization' put: 'lowercase'.
+	config at: 'Vocabulary' put: { #('colour' 'color')}.
+	config at: 'CodeIndentation' put: nil.
+	config at: 'MethodReferenceUsingHash' put: nil.
+	config at: 'MethodStructure' put: nil.
+	config at: 'NotTheFigureX' put: nil.
+	config at: 'CodeLastPeriod' put: 'true'.
+	config at: 'ParagraphLabelEndPeriod' put: 'true'.
+	config at: 'CodeLastPeriodInCaption' put: nil.
+	config at: 'LastPeriodInCode' put: nil.
+	checkers := engine checkersFromConfiguration: config.
+	self assert: checkers size equals: 12.
+]
+
+{ #category : 'running' }
+MiCheckerEngineTest >> testEngineDetectsHeaderMistake [
 	| config results |
 	config := OrderedDictionary new.
-	config at: 'Vocabulary' put: { #('colour' . 'color') }.
+	config at: 'HeaderCapitalization' put: 'uppercase'.
 	results := engine runOn: file withConfiguration: config.
 	self deny: results isEmpty.
-	self assert: results size equals: 1.
-	self assert: (results first explanation includesSubstring: 'colour').
+	self assert: results size equals: 3.
 ]
 
 { #category : 'running' }

src/Microdown-Rules/MicAnchoredSectionTableFigureChecker.class.st

@@ -25,6 +25,11 @@ MicAnchoredSectionTableFigureChecker class >> checkerName [
 	^ 'NotTheFigureX'
 ]
 
+{ #category : 'configuration' }
+MicAnchoredSectionTableFigureChecker >> configureFrom: aConfiguration [
+	^ self
+]
+
 { #category : 'visiting' }
 MicAnchoredSectionTableFigureChecker >> visitParagraph: aMicParagraph [
 	| children |

src/Microdown-Rules/MicCodeIndentationChecker.class.st

@@ -16,6 +16,11 @@ MicCodeIndentationChecker class >> checkerName [
 	^ 'CodeIndentation'
 ]
 
+{ #category : 'configuration' }
+MicCodeIndentationChecker >> configureFrom: aConfiguration [
+	^ self
+]
+
 { #category : 'visiting' }
 MicCodeIndentationChecker >> visitCode: aMicCode [
 	| lines |

src/Microdown-Rules/MicCodeIndentationCheckerTest.class.st

@@ -39,6 +39,18 @@ MicCodeIndentationCheckerTest >> setUp [
 	checker := MicCodeIndentationChecker new.
 ]
 
+{ #category : 'tests' }
+MicCodeIndentationCheckerTest >> testConfigureFromAnyValue [ 
+	checker configureFrom: 'anything'.
+	self assert: checker isOkay.
+]
+
+{ #category : 'tests' }
+MicCodeIndentationCheckerTest >> testConfigureFromNil [
+	checker configureFrom: nil.
+	self assert: checker isOkay.
+]
+
 { #category : 'tests' }
 MicCodeIndentationCheckerTest >> testIndentationCorrect [
 	checker checkProject: fileSystem / 'indentationCorrect.md'.

src/Microdown-Rules/MicEnglishTypographyCheckerTest.class.st

@@ -90,6 +90,20 @@ MicEnglishTypographyCheckerTest >> testConfigureFrom [
 object' 'metaobject'))
 ]
 
+{ #category : 'tests' }
+MicEnglishTypographyCheckerTest >> testConfigureFromAnyValue [
+
+	checker configureFrom: 'anything'.
+	self assert: checker isOkay.
+]
+
+{ #category : 'tests' }
+MicEnglishTypographyCheckerTest >> testConfigureFromNil [
+
+	checker configureFrom: nil.
+	self assert: checker isOkay.
+]
+
 { #category : 'tests' }
 MicEnglishTypographyCheckerTest >> testCorrectFile [
 

src/Microdown-Rules/MicFrenchTypoChecker.class.st

@@ -51,6 +51,11 @@ MicFrenchTypoChecker >> checkString: aString for: anElement [
 		 ]
 ]
 
+{ #category : 'configuration' }
+MicFrenchTypoChecker >> configureFrom: aConfiguration [
+	^ self
+]
+
 { #category : 'adding' }
 MicFrenchTypoChecker >> visitCode: aMicCode [
 	aMicCode caption ifNil: [ ^ self ].

src/Microdown-Rules/MicFrenchTypoCheckerTest.class.st

@@ -54,6 +54,18 @@ MicFrenchTypoCheckerTest >> setUp [
 	checker := MicFrenchTypoChecker new.
 ]
 
+{ #category : 'tests' }
+MicFrenchTypoCheckerTest >> testConfigureFromAnyValue [
+	checker configureFrom: 'anything'.
+	self assert: checker isOkay.
+]
+
+{ #category : 'tests' }
+MicFrenchTypoCheckerTest >> testConfigureFromNil [ 
+	checker configureFrom: nil.
+	self assert: checker isOkay.
+]
+
 { #category : 'tests' }
 MicFrenchTypoCheckerTest >> testCorrect [
 	checker checkProject: fileSystem / 'correct.md'.

src/Microdown-Rules/MicHeaderCapitalizationCheckerTest.class.st

@@ -164,6 +164,27 @@ MicHeaderCapitalizationCheckerTest >> testCheckIdentifyHeaderNotLowercased [
 
 ]
 
+{ #category : 'tests - headers should be lowercased' }
+MicHeaderCapitalizationCheckerTest >> testConfigureFromLowercase [
+
+	checker configureFrom: 'lowercase'.
+	self assert: (checker strategy isKindOf: MicRuleLowercaseHeaderStrategy).
+]
+
+{ #category : 'tests - headers should be lowercased' }
+MicHeaderCapitalizationCheckerTest >> testConfigureFromNil [
+
+	checker configureFrom: nil.
+	self assert: (checker strategy isKindOf: MicRuleLowercaseHeaderStrategy).
+]
+
+{ #category : 'tests - headers should be lowercased' }
+MicHeaderCapitalizationCheckerTest >> testConfigureFromUppercase [
+
+	checker configureFrom: 'uppercase'.
+	self assert: (checker strategy isKindOf: MicRuleUppercaseHeaderStrategy).
+]
+
 { #category : 'tests - headers should be lowercased' }
 MicHeaderCapitalizationCheckerTest >> testWritingBooksCorrect [
 

src/Microdown-Rules/MicLastPeriodChecker.class.st

@@ -36,10 +36,16 @@ MicLastPeriodChecker >> checkMissingPeriodIn: aMicCodeBlock [
 					 codeShouldEndWithPeriod: codeShouldEndWithPeriod) ]
 ]
 
-{ #category : 'visiting' }
-MicLastPeriodChecker >> configureFrom: aBoolean [
+{ #category : 'accessing' }
+MicLastPeriodChecker >> codeShouldEndWithPeriod [
+
+	^ codeShouldEndWithPeriod
+]
 
-	aBoolean = 'true'
+{ #category : 'visiting' }
+MicLastPeriodChecker >> configureFrom: aConfiguration [
+	aConfiguration isNil ifTrue: [ ^ self ]. 
+	aConfiguration = 'true'
 		ifTrue: [ codeShouldEndWithPeriod := true ]
 		ifFalse: [ codeShouldEndWithPeriod := false ]
 ]

src/Microdown-Rules/MicLastPeriodInCaptionCheckerTest.class.st

@@ -119,6 +119,24 @@ MicLastPeriodInCaptionCheckerTest >> testCodeCheckerIdentifyCorrectlyMissingExtr
 		'Text: "This is the famous missing period" in file/codeCaptionMissingPeriod.md contains a mistake: Captions should be terminated with a period (.).'
 ]
 
+{ #category : 'tests' }
+MicLastPeriodInCaptionCheckerTest >> testConfigureFromFalse [
+	checker configureFrom: 'false'.
+	self assert: checker codeShouldEndWithPeriod equals: false.
+]
+
+{ #category : 'tests' }
+MicLastPeriodInCaptionCheckerTest >> testConfigureFromNil [
+	checker configureFrom: nil.
+	self assert: checker codeShouldEndWithPeriod equals: true.
+]
+
+{ #category : 'tests' }
+MicLastPeriodInCaptionCheckerTest >> testConfigureFromTrue [
+	checker configureFrom: 'true'.
+	self assert: checker codeShouldEndWithPeriod equals: true.
+]
+
 { #category : 'tests - missing period' }
 MicLastPeriodInCaptionCheckerTest >> testFigureCheckerChecksCorrectlyMissingExtraPeriod [
 

src/Microdown-Rules/MicMethodReferenceChecker.class.st

@@ -36,6 +36,11 @@ MicMethodReferenceChecker class >> checkerName [
 	^ 'MethodReferenceUsingHash'
 ]
 
+{ #category : 'configuration' }
+MicMethodReferenceChecker >> configureFrom: aConfiguration [
+	^ self
+]
+
 { #category : 'visiting - inline elements' }
 MicMethodReferenceChecker >> visitText: aMicText [
 	| text withHash withhoutHash |

src/Microdown-Rules/MicMethodReferenceCheckerTest.class.st

@@ -36,6 +36,18 @@ MicMethodReferenceCheckerTest >> setUp [
 	checker := MicMethodReferenceChecker new.
 ]
 
+{ #category : 'tests' }
+MicMethodReferenceCheckerTest >> testConfigureFromAnyValue [ 
+	checker configureFrom: 'anything'.
+	self assert: checker isOkay.
+]
+
+{ #category : 'tests' }
+MicMethodReferenceCheckerTest >> testConfigureFromNil [ 
+	checker configureFrom: nil.
+	self assert: checker isOkay.
+]
+
 { #category : 'tests' }
 MicMethodReferenceCheckerTest >> testMixedReferenceDetected [
 	checker checkProject: fileSystem / 'mixedReference.md'.

src/Microdown-Rules/MicMethodStructureChecker.class.st

@@ -44,6 +44,11 @@ MicMethodStructureChecker class >> checkerName [
 	^ 'MethodStructure'
 ]
 
+{ #category : 'configuration' }
+MicMethodStructureChecker >> configureFrom: aConfiguration [
+	^ self
+]
+
 { #category : 'visiting' }
 MicMethodStructureChecker >> visitCode: aMicCode [
 	| lines firstLine secondLine |

src/Microdown-Rules/MicMethodStructureCheckerTest.class.st

@@ -56,6 +56,18 @@ MicMethodStructureCheckerTest >> setUp [
 	checker := MicMethodStructureChecker new.
 ]
 
+{ #category : 'tests' }
+MicMethodStructureCheckerTest >> testConfigureFromAnyValue [ 
+	checker configureFrom: 'anything'.
+	self assert: checker isOkay.
+]
+
+{ #category : 'tests' }
+MicMethodStructureCheckerTest >> testConfigureFromNil [ 
+	checker configureFrom: nil.
+	self assert: checker isOkay.
+]
+
 { #category : 'tests' }
 MicMethodStructureCheckerTest >> testMethodCorrect [
 	checker checkProject: fileSystem / 'methodCorrect.md'.

src/Microdown-Rules/MicParagraphLabelChecker.class.st

@@ -60,7 +60,10 @@ MicParagraphLabelChecker >> checkMissingPeriodIn: aMicHeader [
 
 { #category : 'visiting' }
 MicParagraphLabelChecker >> configureFrom: aConfiguration [
-
+	aConfiguration isNil ifTrue: [ ^ self ].
+	aConfiguration = 'true'
+		ifTrue: [ labelShouldEndWithPeriod := true ]
+		ifFalse: [ labelShouldEndWithPeriod := false ]
 ]
 
 { #category : 'visiting' }
@@ -83,6 +86,12 @@ MicParagraphLabelChecker >> initialize [
 	levelForParagraph := 4.
 ]
 
+{ #category : 'accessing' }
+MicParagraphLabelChecker >> labelShouldEndWithPeriod [
+
+	^ labelShouldEndWithPeriod
+]
+
 { #category : 'accessing' }
 MicParagraphLabelChecker >> levelForParagraph [
 

src/Microdown-Rules/MicParagraphLabelCheckerTest.class.st

@@ -83,6 +83,24 @@ MicParagraphLabelCheckerTest >> setUp [
 	checker := MicParagraphLabelChecker new.
 ]
 
+{ #category : 'tests' }
+MicParagraphLabelCheckerTest >> testConfigureFromFalse [ 
+	checker configureFrom: 'false'.
+	self assert: checker labelShouldEndWithPeriod equals: false.
+]
+
+{ #category : 'tests' }
+MicParagraphLabelCheckerTest >> testConfigureFromNil [
+	checker configureFrom: nil.
+	self assert: checker labelShouldEndWithPeriod equals: true.
+]
+
+{ #category : 'tests' }
+MicParagraphLabelCheckerTest >> testConfigureFromTrue [ 
+	checker configureFrom: 'true'.
+	self assert: checker labelShouldEndWithPeriod equals: true.
+]
+
 { #category : 'tests' }
 MicParagraphLabelCheckerTest >> testLevel1NotChecked [
 	checker checkProject: fileSystem / 'level1.md'.

src/Microdown-Rules/MicReferencesCheckerTest.class.st

@@ -10,6 +10,11 @@ Class {
 	#tag : 'References'
 }
 
+{ #category : 'public - name' }
+MicReferencesCheckerTest class >> checkerName [ 
+	^ 'ReferenceChecks'
+]
+
 { #category : 'running' }
 MicReferencesCheckerTest >> generateFilesystemExample [
 	| file |
@@ -64,6 +69,18 @@ MicReferencesCheckerTest >> setUp [
 	checker := MicAnchoredSectionTableFigureChecker new.
 ]
 
+{ #category : 'running' }
+MicReferencesCheckerTest >> testConfigureFromAnyValue [ 
+	checker configureFrom: 'anything'.
+	self assert: checker isOkay.
+]
+
+{ #category : 'running' }
+MicReferencesCheckerTest >> testConfigureFromNil [
+	checker configureFrom: nil.
+	self assert: checker isOkay.
+]
+
 { #category : 'running' }
 MicReferencesCheckerTest >> testFigureCorrect [
 	checker checkProject: fileSystem / 'figureCorrect.md'.

src/Microdown-Rules/MicRuleHeaderChecker.class.st

@@ -74,6 +74,12 @@ MicRuleHeaderChecker >> shouldCapitalizedWord: aString [
 	^ (uncapitalizableText includes: normalized) not
 ]
 
+{ #category : 'accessing' }
+MicRuleHeaderChecker >> strategy [
+
+	^ strategy
+]
+
 { #category : 'initialization' }
 MicRuleHeaderChecker >> verifyLowercase [