Skip to content

Conversation

@patrickbitzer
Copy link
Contributor

@patrickbitzer patrickbitzer commented Oct 23, 2024

I had the phenomenon that when I had set a OneToManyRelation field with the Inline Search type, the PathFormatter was not applied there. The problem occurres only when the user is in not editable mode.

image

I have made an adjustment that fixes the problem.

image-20241022-123834

@github-actions
Copy link

github-actions bot commented Oct 23, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@ghost ghost added the Pimcore:ToDo label Oct 23, 2024
@patrickbitzer patrickbitzer changed the title HOTFIX: display the nice path if field type combo is not editable BUG: display the nice path if field type combo is not editable Oct 23, 2024
@patrickbitzer
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@patrickbitzer
Copy link
Contributor Author

I updated the description

@blankse
Copy link
Contributor

blankse commented Oct 23, 2024

@patrickbitzer Target branch for bug fixes should be 1.6. Can you rebase it?

@patrickbitzer patrickbitzer changed the base branch from 1.x to 1.6 October 24, 2024 10:38
@patrickbitzer patrickbitzer force-pushed the hotfix/display-nicepath-in-combo-field-of-many-to-one-relation-field branch from 8bf1af8 to c9a441c Compare October 24, 2024 10:42
@patrickbitzer
Copy link
Contributor Author

@blankse maybe done.

@blankse
Copy link
Contributor

blankse commented Oct 24, 2024

@patrickbitzer You still have commits from 1.x in your branch. You need to rebase with the --onto option to remove them:
git rebase --onto origin/1.6 origin/1.x
Then, you need to push with the --force option:
git push --force

@patrickbitzer patrickbitzer force-pushed the hotfix/display-nicepath-in-combo-field-of-many-to-one-relation-field branch from c9a441c to a393318 Compare October 24, 2024 11:10
@patrickbitzer
Copy link
Contributor Author

@blankse sorry. I have done now

@sonarqubecloud
Copy link

@mattamon mattamon self-assigned this Nov 8, 2024
@mattamon
Copy link
Contributor

mattamon commented Nov 8, 2024

@patrickbitzer Could you explain this a little more? What do you mean by inline search type?
I cannot reproduce this with my local instance.

@blankse
Copy link
Contributor

blankse commented Jan 13, 2025

@mattamon I could reproduce it:

  1. Create a Many-To-One Relation field with Formatter Service and Display Mode "Inline Search"
  2. Create an object and fill the field => The formatter is used correctly
  3. Change the field definition to "Not editable"
  4. Reload the object => The formatter is not used and you see the path of the relation object

@IronSean
Copy link

@mattamon we're also experiencing this with our clients.

@blankse
Copy link
Contributor

blankse commented Apr 4, 2025

@mattamon Still can't reproduce it?

@mattamon
Copy link
Contributor

mattamon commented Apr 4, 2025

@blankse sorry I am no longer working on this. @robertSt7 can you please take over.

@ghost ghost assigned robertSt7 and unassigned mattamon Apr 4, 2025
@robertSt7 robertSt7 added this to the 1.7.8 milestone Apr 9, 2025
@robertSt7 robertSt7 merged commit 1a6a1af into pimcore:1.7 Apr 9, 2025
10 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Apr 9, 2025
@robertSt7
Copy link
Contributor

@patrickbitzer Thanks for fixing displaying of the path

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants