Update word_clock.py to properly handle cases when minutes == 0 #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
explicitly handle cases when minutes == 0
githubguy007
changed the title
Added features... Added UTC offset to display in local timezone Decoupled display update time & NTP sync - Now updates the display every minute - Update NTP time every 10 minutes (user code defined) Optional digital clock on the bottom of the display H H : M M to help with debugging.
Restored WHITE & GRAY to original values
Just helps me see word layout, line by line
|
Looks like this is conflicted and has grown beyond its original scope somewhat. If you don't mind, a single commit for the minutes == 0 fix in a feature branch would be appreciated! There's probably other good stuff here, too, but one step at a time. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
explicitly handle cases when minutes == 0, otherwise we potentially show next hour.