Skip to content

pd: support schema change by tls#5708

Open
HuSharp wants to merge 3 commits intopingcap:masterfrom
HuSharp:update_pd_member
Open

pd: support schema change by tls#5708
HuSharp wants to merge 3 commits intopingcap:masterfrom
HuSharp:update_pd_member

Conversation

@HuSharp
Copy link
Contributor

@HuSharp HuSharp commented Aug 8, 2024

What problem does this PR solve?

What is changed and how does it work?

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test
  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.

@ti-chi-bot ti-chi-bot bot requested review from howardlau1999 and shonge August 8, 2024 09:15
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 8, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from husharp, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the size/XL label Aug 8, 2024
@HuSharp
Copy link
Contributor Author

HuSharp commented Aug 8, 2024

/test all

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 8, 2024

@HuSharp: No presubmit jobs available for pingcap/tidb-operator@master

Details

In response to this:

/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@csuzhangxc
Copy link
Member

csuzhangxc commented Aug 8, 2024

/run-all-tests

@codecov-commenter
Copy link

codecov-commenter commented Aug 8, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 66.66667% with 48 lines in your changes missing coverage. Please review.

Project coverage is 61.55%. Comparing base (a16b2e8) to head (a13b241).
Report is 6 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5708      +/-   ##
==========================================
+ Coverage   57.19%   61.55%   +4.35%     
==========================================
  Files         259      262       +3     
  Lines       33233    45551   +12318     
==========================================
+ Hits        19008    28039    +9031     
- Misses      12291    15511    +3220     
- Partials     1934     2001      +67
Flag Coverage Δ
e2e 34.09% <18.75%> (?)
unittest 57.05% <64.58%> (-0.15%) ⬇️

csuzhangxc
csuzhangxc reviewed Aug 8, 2024
View reviewed changes
@csuzhangxc
Copy link
Member

csuzhangxc commented Aug 9, 2024

/run-pull-e2e-kind-across-kubernetes

@csuzhangxc
Copy link
Member

csuzhangxc commented Aug 13, 2024

/run-all-tests

1 similar comment
@HuSharp
Copy link
Contributor Author

HuSharp commented Aug 13, 2024

/run-all-tests

@ti-chi-bot ti-chi-bot bot removed the needs-rebase label Aug 14, 2024
@HuSharp
Copy link
Contributor Author

HuSharp commented Aug 14, 2024

/run-all-tests

@HuSharp
Copy link
Contributor Author

HuSharp commented Aug 14, 2024

/run-pull-e2e-kind-across-kubernetes

@HuSharp
Copy link
Contributor Author

HuSharp commented Aug 14, 2024

/run-pull-e2e-kind

@csuzhangxc csuzhangxc mentioned this pull request Sep 3, 2024
Open
@HuSharp
Copy link
Contributor Author

HuSharp commented Sep 12, 2024

/run-all-tests

@HuSharp
add tls
16e4355 
Signed-off-by: husharp <ihusharp@gmail.com>
@ti-chi-bot ti-chi-bot bot added size/XXL and removed size/XL labels Sep 12, 2024
@HuSharp
Copy link
Contributor Author

HuSharp commented Sep 12, 2024

/run-all-tests

@HuSharp
make test happy
1db5286 
Signed-off-by: husharp <ihusharp@gmail.com>
@HuSharp HuSharp mentioned this pull request Sep 13, 2024
Merged
7 tasks
@HuSharp
Copy link
Contributor Author

HuSharp commented Sep 14, 2024

/run-all-tests

@ti-chi-bot ti-chi-bot mentioned this pull request Nov 7, 2024
Merged
7 tasks
This was referenced Nov 7, 2024
Merged
Merged
@csuzhangxc
Copy link
Member

csuzhangxc commented Nov 13, 2024

/run-all-tests

@csuzhangxc
Copy link
Member

csuzhangxc commented Nov 13, 2024

/run-pull-e2e-kind

2 similar comments
@csuzhangxc
Copy link
Member

csuzhangxc commented Nov 13, 2024

/run-pull-e2e-kind

@csuzhangxc
Copy link
Member

csuzhangxc commented Nov 13, 2024

/run-pull-e2e-kind

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@csuzhangxc csuzhangxc csuzhangxc left review comments

@howardlau1999 howardlau1999 Awaiting requested review from howardlau1999

@shonge shonge Awaiting requested review from shonge

Assignees

No one assigned

Labels

size/XXL

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@HuSharp @csuzhangxc @codecov-commenter