Skip to content

Add TiCI support to TidbCluster with TiFlash integration and example#6699

Merged
ti-chi-bot[bot] merged 57 commits intopingcap:release-1.xfrom
3pointer:support_tici
Feb 25, 2026
Merged

Add TiCI support to TidbCluster with TiFlash integration and example#6699
ti-chi-bot[bot] merged 57 commits intopingcap:release-1.xfrom
3pointer:support_tici

Conversation

@3pointer
Copy link
Contributor

@3pointer 3pointer commented Feb 2, 2026

Summary

This PR adds TiCI (meta/worker) as a first‑class component in TidbCluster, wires it into the controller sync loop, integrates TiFlash with TiCI config, and provides an end‑to‑end example (including MinIO + FTS verification) for local testing.

For more details about how to run tici via tidb-operator: please refer to examples/tici/readme.md

Key Changes

  • API/Spec/Status
    • Added TiCI spec/status, new member types, labels, defaulting, and validation.
  • Controller/Manager
    • New TiCI member manager to create services, configmaps, and statefulsets for meta/worker.
    • Integrated TiCI sync into the control loop.
  • TiFlash integration
    • Injected TiCI config into TiFlash; reader now binds to a literal IP and advertises the pod DNS.
    • Added log routing option to stdout for searchlib.
  • Volumes
    • Added TiCI member types to volume modifier.
    • Avoided PVC VolumeName lookups when unset.
  • Examples
    • New examples/tici/ with tici-tc.yaml and README (MinIO + FTS verification flow).

##Testing

  • Not run in CI.
  • Manual verification flow documented in examples/tici/README.md.

Notes / Operational Considerations

  • TiFlash TiCI reader requires a literal bind address; hostname-only addresses cause startup failures.
  • On kind/podman, pod PID limits must be removed (TasksMax/infinity) to avoid newosproc.
  • If reusing old TiFlash PVs, PD may reject duplicated store addresses; wipe PVC or delete the store.

Follow‑ups

  • Consider formalizing TiCDC changefeed creation for TiCI if desired.
  • Add unit tests for TiCI manager and config rendering.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Feb 2, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@codecov-commenter
Copy link

codecov-commenter commented Feb 2, 2026

Codecov Report

❌ Patch coverage is 5.76471% with 801 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (release-1.x@9ab6710). Learn more about missing BASE report.

Additional details and impacted files
@@              Coverage Diff               @@
##             release-1.x    #6699   +/-   ##
==============================================
  Coverage               ?   56.42%           
==============================================
  Files                  ?      266           
  Lines                  ?    39210           
  Branches               ?        0           
==============================================
  Hits                   ?    22124           
  Misses                 ?    15002           
  Partials               ?     2084           
Flag Coverage Δ
unittest 56.42% <5.76%> (?)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@liubog2008
Copy link
Member

please submit pr to release-1.x

@liubog2008 liubog2008 changed the base branch from release-1.6 to release-1.x February 2, 2026 09:52
@liubog2008
Copy link
Member

/run-all-tests

@csuzhangxc
Copy link
Member

/run-all-tests

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Feb 24, 2026

@3pointer: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-e2e-kind-dmcluster 32b7a77 link false /test pull-e2e-kind-dmcluster
pull-e2e-kind-basic 32b7a77 link false /test pull-e2e-kind-basic
pull-e2e-kind-scale-simultaneously 32b7a77 link false /test pull-e2e-kind-scale-simultaneously
pull-e2e-kind-tidbcluster 32b7a77 link false /test pull-e2e-kind-tidbcluster
pull-e2e-kind-across-kubernetes 32b7a77 link false /test pull-e2e-kind-across-kubernetes
pull-e2e-kind-tngm 32b7a77 link false /test pull-e2e-kind-tngm
pull-e2e-kind-serial 32b7a77 link false /test pull-e2e-kind-serial
pull-e2e-kind-br 32b7a77 link false /test pull-e2e-kind-br

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@csuzhangxc
Copy link
Member

/run-pull-e2e-kind

@csuzhangxc
Copy link
Member

/run-pull-e2e-kind-across-kubernetes

@csuzhangxc
Copy link
Member

/run-pull-e2e-kind-br

@csuzhangxc
Copy link
Member

/run-pull-e2e-kind-tikv-scale-simultaneously

@csuzhangxc
Copy link
Member

/run-pull-e2e-kind

@csuzhangxc
Copy link
Member

/run-pull-e2e-kind-br

@csuzhangxc
Copy link
Member

/run-pull-e2e-kind-across-kubernetes

@csuzhangxc
Copy link
Member

/run-pull-e2e-kind-tikv-scale-simultaneously

@csuzhangxc
Copy link
Member

/run-pull-e2e-kind

@ti-chi-bot ti-chi-bot bot added the lgtm label Feb 25, 2026
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Feb 25, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csuzhangxc, JaySon-Huang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Feb 25, 2026

[LGTM Timeline notifier]

Timeline:

  • 2026-02-25 12:25:18.222700271 +0000 UTC m=+271390.737494870: ☑️ agreed by csuzhangxc.

@ti-chi-bot ti-chi-bot bot added the approved label Feb 25, 2026
@ti-chi-bot ti-chi-bot bot merged commit 3851ab1 into pingcap:release-1.x Feb 25, 2026
12 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants