-
Notifications
You must be signed in to change notification settings - Fork 6.1k
ddl: cancel the job context before rolling back (#64130) #64203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release-8.5
Are you sure you want to change the base?
ddl: cancel the job context before rolling back (#64130) #64203
Conversation
Signed-off-by: ti-chi-bot <[email protected]>
|
@tangenta This PR has conflicts, I have hold it. |
|
@ti-chi-bot: ## If you want to know how to resolve it, please read the guide in TiDB Dev Guide. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## release-8.5 #64203 +/- ##
================================================
Coverage ? 77.0262%
================================================
Files ? 1665
Lines ? 461230
Branches ? 0
================================================
Hits ? 355268
Misses ? 84205
Partials ? 21757
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
@ti-chi-bot: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This is an automated cherry-pick of #64130
What problem does this PR solve?
Issue Number: close #64129
Problem Summary: See #64129
What changed and how does it work?
When a reorganization timeout error occurs,
ADMIN CANCELchange the state of the DDL job and the job context is not canceled. As a result, background global tasks continue to run and never complete.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.