net: pool bufio reader and writer to reduce memory allocation (#776)#1085
net: pool bufio reader and writer to reduce memory allocation (#776)#1085Samriddha9619 wants to merge 1 commit intopingcap:mainfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @Samriddha9619. Thanks for your PR. I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Welcome @Samriddha9619! It looks like this is your first PR to pingcap/tiproxy 🎉 |
What problem does this PR solve?
Issue Number: close #776
Problem Summary:
In short-lived connection workloads, buffered IO is created frequently, leading to heavy memory allocation and GC pressure.
What is changed and how it works:
sync.Poolforbufio.Readerandbufio.WriterinbasicReadWriter.pooledflag to safely manage the buffer lifecycle.freeBasicReadWriterto recursively unwrap connection layers (TLS, compression) and return standard-sized buffers to the pool on connection close to prevent memory leaks.Check List
Tests - [x] Unit test
Notable changes
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.