Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @Samriddha9619. Thanks for your PR. I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
98dd2f2 to
a938682
Compare
a938682 to
8c3b614
Compare
What problem does this PR solve?
Issue Number: close #951
Problem Summary:
Issue - 951
What is changed and how it works:
Removed the early return in
buildClientConfigandBuildClientTLSConfigto ensure the full TLS config (with certificate hooks) is built even when CA verification is skipped.Check List
Tests
Notable changes
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.