Added checks to prevent Same Origin Policy#44
Open
BrettSheleski wants to merge 1 commit intopipwerks:masterfrom
Open
Added checks to prevent Same Origin Policy#44BrettSheleski wants to merge 1 commit intopipwerks:masterfrom
BrettSheleski wants to merge 1 commit intopipwerks:masterfrom
Conversation
|
Thanks for this, spared me a few headaches ! Should merge. |
datarunners
approved these changes
Aug 10, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added this as we were hosting SCORM packages made by various authors but not using a SCORM engine on our site. We found that if another site happened open a SCO in a new tab/window it caused a Same Origin Policy security exception resulting in the content to not render.
I added a check to prevent this exception from occurring and instead return a null API object.