refactor: move link logic to a separate module#49
Open
claby2 wants to merge 5 commits intoplamorg:masterfrom
Open
refactor: move link logic to a separate module#49claby2 wants to merge 5 commits intoplamorg:masterfrom
claby2 wants to merge 5 commits intoplamorg:masterfrom
Conversation
virchau13
requested changes
Apr 29, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors linking functionality by moving it to a separate module,
src/linker.rs. It removes some overly verbose flags fromambit syncand also creates another subcommand invoked withambit move. More tests need to be added to thelinkermodule; however, this PR makes testing easy asAmbitPathscan be passed toLinker. This means that temporary directory paths can be passed toLinker.