bake virtio 0.1.185 for windows server 2012 #1425
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![windsurf-bot[bot]](https://avatars.githubusercontent.com/in/1066231?s=60&v=4){kind=small}
| finalBootIndex, err = virtv2v.GetBootableVolumeIndex(vminfo.VMDisks) | ||
| if err != nil { | ||
| return -1, errors.Wrap(err, "Failed to get bootable volume index") | ||
| return -1, "", errors.Wrap(err, "Failed to get bootable volume index") |
Contributor
There was a problem hiding this comment.
The error return statement doesn't match the updated function signature. You need to return an empty string for the osRelease parameter when returning an error.
Suggested change
| return -1, "", errors.Wrap(err, "Failed to get bootable volume index") | |
| return -1, "", errors.Wrap(err, "Failed to get bootable volume index") |
| if useSingleDisk { | ||
| productName, err = RunCommandInGuest(diskPath, fmt.Sprintf("inspect-get-product-name %s", osPath), false) | ||
| } else { | ||
| productName, err = RunCommandInGuestAllVolumes(disks, "inspect-get-product-name", false, osPath) |
Contributor
There was a problem hiding this comment.
There's an issue with how inspect-get-product-name is called. The osPath parameter should be part of the command string rather than passed as a separate argument.
Suggested change
| productName, err = RunCommandInGuestAllVolumes(disks, "inspect-get-product-name", false, osPath) | |
| productName, err = RunCommandInGuestAllVolumes(disks, fmt.Sprintf("inspect-get-product-name %s", osPath), false) |
OmkarDeshpande7
force-pushed
the
private/main/omkard/bake-virtio-0.1.189
branch
2 times, most recently
from
6f537b3 to
82466ac
Compare
OmkarDeshpande7
force-pushed
the
private/main/omkard/bake-virtio-0.1.189
branch
from
a33af47 to
4d7f0f0
Compare
OmkarDeshpande7
force-pushed
the
private/main/omkard/bake-virtio-0.1.189
branch
from
4d7f0f0 to
62b71b0
Compare
OmkarDeshpande7
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
This PR pre-bakes specific virtio version (0.1.189) to VJB VM. Now during migration v2v-helper determines the OS release and version and switches to this virtio-win version in case of windows server 2012
Which issue(s) this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged)fixes #1409
Special notes for your reviewer
Testing done
TBD