Skip to content

Update site deletion test #6101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aerosol wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update site deletion test #6101

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions test/plausible_web/controllers/site_controller_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -977,6 +977,26 @@ defmodule PlausibleWeb.SiteControllerTest do
insert(:spike_notification, site: site)
insert(:drop_notification, site: site)

on_ee do
{:ok, g1} = Plausible.Goals.create(site, %{"page_path" => "/1"})
{:ok, g2} = Plausible.Goals.create(site, %{"event_name" => "/2"})
Copy link
Contributor

@apata apata Feb 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{:ok, g2} = Plausible.Goals.create(site, %{"event_name" => "/2"})
{:ok, g2} = Plausible.Goals.create(site, %{"event_name" => "Signup"})

a bit more realistic

{:ok, [g1, g2]}

{:ok, _} =
Plausible.Funnels.create(
site,
"funnel1",
[%{"goal_id" => g1.id}, %{"goal_id" => g2.id}]
)

{:ok, _} =
Plausible.Funnels.create(
site,
"funnel2",
[%{"goal_id" => g2.id}, %{"goal_id" => g1.id}]
)
end

delete(conn, "/#{site.domain}")

refute Repo.exists?(from(s in Plausible.Site, where: s.id == ^site.id))
Expand Down
Loading