Fix regression: Drop revenue metrics when not allowed on the dashboard#6167
Merged
RobertJoonas merged 2 commits intomasterfrom Mar 17, 2026
Merged
Fix regression: Drop revenue metrics when not allowed on the dashboard#6167RobertJoonas merged 2 commits intomasterfrom
RobertJoonas merged 2 commits intomasterfrom
Conversation
RobertJoonas
force-pushed
the
top-stats-revenue-fix
branch
from
cd6f8df to
f224e90
Compare
RobertJoonas
force-pushed
the
top-stats-revenue-fix
branch
from
f224e90 to
7bceaf8
Compare
|
1 similar comment
|
aerosol
approved these changes
Mar 17, 2026
Member
aerosol
left a comment
aerosol
left a comment
There was a problem hiding this comment.
It does fail on master so I suppose it's ok? Really not sure about the flags we carry around to make decisions and what the implications can be. Approving in hope someone else will have a look too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Bring back the Top Stats behaviour that revenue metrics are dropped from the query (instead of returning an error) when the site owner doesn't have a sufficient subscription. The bug was introduced with the change to a new /query endpoint for top stats (#6035)
Tests
Changelog
Documentation
Dark mode