Skip to content

Main graph fixes#6169

Merged
RobertJoonas merged 2 commits intomasterfrom
fix-graph
Mar 17, 2026
Merged

Main graph fixes#6169
RobertJoonas merged 2 commits intomasterfrom
fix-graph

Conversation

@RobertJoonas
Copy link
Contributor

@RobertJoonas RobertJoonas commented Mar 17, 2026

Changes

Fixes three bugs:

  1. Fix main graph crashing when hovering on a time bucket that includes only comparison data, and then changing the query period with a keyboard shortcut. Before (master staging) -> After (this review env). Note that the actual crash can be difficult to reproduce. I assume it's timing-related, but not fully sure why. In any case, in the page console you can clearly see master throwing errors, but review env not.
  2. Fix displaying tooltips for original-range-only time buckets when comparison range is shorter. Before (master staging) -> After (this review env)
  3. Do not link to __blank__ periods when clicking on a time bucket that includes only comparison data (use the same before/after links as 1) to reproduce)

Currently, if the comparison period is longer, the backend fills the "overflow" comparison period with empty metrics, which is not correct, as there is actually data in those buckets.

image

Hovering anywhere in that right hand side area will display lots of console errors because the graph-tooltip.js module is currently not accounting for missing values. This PR starts doing that to avoid the crash, and on top of that, not even trying to render a tooltip. This will be fixed properly with #6152 and #6159.

Note: I tried to add an E2E test for both of these fixes, but testing the canvas is currently insanely difficult. TODO: write E2E tests once #6159 has rebuilt line-graph as SVG.

Tests

  • Automated tests have been added

Changelog

  • This PR does not make a user-facing change

Documentation

  • This change does not need a documentation update

Dark mode

  • This PR does not change the UI

@github-actions
Copy link

Preview environment👷🏼‍♀️🏗️
PR-6169

@RobertJoonas RobertJoonas requested a review from a team March 17, 2026 14:50
@RobertJoonas RobertJoonas added this pull request to the merge queue Mar 17, 2026
Merged via the queue into master with commit 5d857fa Mar 17, 2026
25 checks passed
@RobertJoonas RobertJoonas deleted the fix-graph branch March 17, 2026 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants