Move subscription settings page content into a LiveView#6170
Merged
Move subscription settings page content into a LiveView#6170
Conversation
Prepares the page to host the choose_plan modal as a LiveComponent in a follow-up PR. Pure refactor, no UX changes. - Extract subscription page content into a new SubscriptionSettings LiveView - Move data loading out of the controller and into the LiveView - Embed the LiveView in the existing settings layout via live_render
ukutaht
reviewed
Mar 17, 2026
Contributor
ukutaht
left a comment
ukutaht
left a comment
There was a problem hiding this comment.
Looks good, just a couple comments
- Render SubscriptionSettings LiveView directly from the router instead of via a controller action and template - Update the shared settings layout to work without a request object - Move view helpers from SettingsView to the billing components module
sanne-san
force-pushed
the
sanne-subscription-settings-liveview
branch
from
eabfad4 to
11ad786
Compare
zoldar
reviewed
Mar 18, 2026
zoldar
reviewed
Mar 18, 2026
Co-authored-by: Adrian Gruntkowski <adrian.gruntkowski@gmail.com>
Co-authored-by: Adrian Gruntkowski <adrian.gruntkowski@gmail.com>
Co-authored-by: Adrian Gruntkowski <adrian.gruntkowski@gmail.com>
Co-authored-by: Adrian Gruntkowski <adrian.gruntkowski@gmail.com>
sanne-san
force-pushed
the
sanne-subscription-settings-liveview
branch
from
499427c to
73ab60f
Compare
- Move billing helpers to a dedicated Helpers module - Add a CurrentPath plug to the settings pipeline so we can avoid all the branching in the layout template - Remove conn dependency from the settings layout
sanne-san
force-pushed
the
sanne-subscription-settings-liveview
branch
from
73ab60f to
2c9f483
Compare
zoldar
reviewed
Mar 18, 2026
zoldar
reviewed
Mar 18, 2026
zoldar
reviewed
Mar 18, 2026
zoldar
reviewed
Mar 18, 2026
- Use `conn.request_path` instead of `Path.join` in CurrentPath plug
- Remove unused `%Plug.Conn{}` clause from `account_settings_sidebar`
- Use dot notation for always-present assigns in `account_settings_sidebar`
zoldar
reviewed
Mar 18, 2026
Comment on lines
+99
to
+100
| current_team = assigns.current_team | ||
| current_team_role = assigns.current_team_role |
Contributor
There was a problem hiding this comment.
These assigns are indeed always set if AuthPlug is present in the pipeline - we just need to keep in mind that they both might be nil. But we should be good here 👍
Contributor
Author
|
@zoldar thanks for all the improvements! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Prepares the page to host the choose_plan modal as a LiveComponent in a follow-up PR. Pure refactor, no UX changes.
Tests
Changelog
Documentation
Dark mode