Draft
Conversation
* Add a new response structure: a separate `comparison_results` field, used only when comparing in a time-dimensional query. * Add `meta.time_label_result_indices` to response (exclusive to internal API). Makes it easier for FE to find buckets for time labels.
This is currently only used by the main graph, which is going to move to a new endpoint in this PR. * The CSV export is currently ignoring comparisons * the `&compare=previous_period` option in Stats API v1 is ignored by the timeseries endpoint
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
A cleaned up, rebased version of #6152, including only the backend changes to support migrating main graph to the API v2 based
/queryendpoint.While the backend part is done, this PR is not ready to be deployed as it would break the main graph on the dashboard without the necessary frontend changes. Those are currently being implemented in #6159.
Summary of changes introduced in this PR:
include.time_labelsis set, also includemeta.time_label_result_indices(right next tometa.time_labelsthemselves). This helps to avoid searching for rows corresponding to a time label on the client side.main_graph_test.exs- populate_stats and other tests setup remained mostly the same, but the request is now made against the new endpoint and the assertions on the returned data structures have changed significantly.Tests
Changelog
Documentation
Dark mode