David/GitHub action update cdn #389
Conversation
There was a problem hiding this comment.
non-zero or zero exit, it matters:
if sys.exit(0), the action is marked as success.
if sys.exit(1), the action is marked as a failure.
When should it marked as failure? When as success?
Should be marked as failure when the user needs to be notified as something.
Careful with the prints. It would be nice if w/ action success/failure status, the subtitle was whatever link the user had to follow. This is what github pages does when a new pages is published.
Can this also automatically update the CHANGELOG is a second commit?
src/py/scripts/update_cdn.py
Outdated
| ) | ||
| if not reteval: | ||
| print(f"The branch {branch} already exists") | ||
| sys.exit(0) |
There was a problem hiding this comment.
exit non-zero and print to stderr
| if brc_eval: | ||
| msg = err.decode() | ||
| if "HTTP 404" not in msg: | ||
| print(msg) # unexpected errors |
| ["gh", "api", f"repos/{REPO}/branches/{branch}", "--silent"] | ||
| ) | ||
|
|
||
| if brc_eval: |
There was a problem hiding this comment.
condicional un poco enredado
| print(msg) # unexpected errors | ||
| sys.exit(1) | ||
| else: | ||
| print(f"The branch {branch} already exists") |
| issues = json.loads(brc.decode()) | ||
| if issues: | ||
| for issue in issues: | ||
| if issue.get("state") == "OPEN": |
| run: uv run --python 3.12 --with "$CHANGELOGTXT" changelogtxt check-tag -t "$TAG" | ||
| - name: Delete invalid tag | ||
| if: failure() | ||
| run: git push --delete origin $TAG |
| run: | | ||
| git fetch origin master | ||
| git switch master | ||
| cat ./CHANGELOG.txt > target.txt |
There was a problem hiding this comment.
git show origin/master:src/py/CHANGELOG.txt > target or something like that. Also fetch has a filter flag to specify certain files
|
@davidangarita1 some changes were not resolved and I want to re-review the script. Please add more logging, especially intermediate values. |
automatic update of plotly.js